Merged
Conversation
uranusjr
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
rawwar and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
pierrejeambrun
approved these changes
Apr 17, 2025
Member
|
LGTM supposing the CI agrees :) |
Switch the last standing usage in CLI to use Pydantic instead. I think we can drop the dependency outright now? Let's see.
uranusjr
force-pushed
the
rewrite-dag-command-schema
branch
from
da09c55 to
c33f114
Compare
Contributor
|
We still have marshmallow here: |
ephraimbuddy
approved these changes
Apr 17, 2025
vincbeck
approved these changes
Apr 17, 2025
aritra24
approved these changes
Apr 17, 2025
Collaborator
aritra24
left a comment
aritra24
left a comment
There was a problem hiding this comment.
Mostly lgtm. Just 1 question
uranusjr
force-pushed
the
rewrite-dag-command-schema
branch
from
308fc94 to
4a3f1ea
Compare
uranusjr
force-pushed
the
rewrite-dag-command-schema
branch
from
4a3f1ea to
c669dcd
Compare
ashb
pushed a commit
that referenced
this pull request
Apr 19, 2025
(cherry picked from commit bc54c3f)
This was referenced May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the last standing usage in CLI to use Pydantic instead. I think we can drop the dependency outright now? Let's see.